Support for monad transformers; resolves #7.#23
Support for monad transformers; resolves #7.#23nsaunders wants to merge 1 commit intohoodunit:masterfrom
Conversation
| Aff.runAff_ | ||
| ( | ||
| case _ of | ||
| Left e -> liftEffect do | ||
| logger.logError $ message e | ||
| writeResponse res (internalError (StringBody "")) | ||
| _ -> | ||
| pure unit | ||
| ) |
There was a problem hiding this comment.
I found the change from launchAff_ to runAff_ to be necessary in case runM throws an error. The practical difference is that runAff_ allows errors to be handled where launchAff_ results in the server crashing.
|
This seems good on the face of it, but I'll give it a better look over when I get the chance. |
nsaunders
force-pushed
the
transformers
branch
from
ae40e19 to
6c868f3
Compare
nsaunders
force-pushed
the
transformers
branch
from
6c868f3 to
1b700a7
Compare
|
@hoodunit I just noticed that you updated Payload to work with v0.15, which is wonderful! If I resolve the conflicts in this PR, would you consider merging? |
|
@nsaunders I know I said this last time as well, but yes, I will give it a try and get back to you. I've been working with this library a bit more actively lately. My main concern is to make sure it doesn't make the compiler errors even more gnarly and maybe to see if/how this should work on the client as well. |
2 participants
See #7.